Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tools.custom_builder): Handle multiple instance of the same plugin correctly #15630

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix(tools.custom_builder): Handle multiple instance of the same plugin correctly #15630

merged 1 commit into from
Jul 17, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jul 16, 2024

Summary

The existing code only handles the data-format field correctly for single instances of the same plugin as we overwrite the parsers/serializers for each instance.

This PR fixes the issue and additionally restructures the code to be able to add test-cases and do so for previous issues.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15627

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jul 16, 2024
@srebhan srebhan mentioned this pull request Jul 16, 2024
Closed
@srebhan srebhan self-assigned this Jul 16, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 17, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Jul 17, 2024
@powersj powersj removed their assignment Jul 17, 2024
@DStrand1 DStrand1 merged commit a3a8a8c into influxdata:master Jul 17, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.2 milestone Jul 17, 2024
powersj pushed a commit that referenced this pull request Jul 22, 2024
@srebhan @powersj
fix(tools.custom_builder): Handle multiple instance of the same plugi…
4efc3cf 
…n correctly (#15630)

(cherry picked from commit a3a8a8c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@powersj powersj powersj approved these changes

Assignees

@DStrand1 DStrand1

Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.31.2
Development

Successfully merging this pull request may close these issues.

Bug in custom_builder scanning of parsers
3 participants
@srebhan @powersj @DStrand1